[SPARK-29060][SQL] Add tree traversal helper for adaptive spark plans#25764
Closed
maryannxue wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-29060][SQL] Add tree traversal helper for adaptive spark plans#25764maryannxue wants to merge 1 commit intoapache:masterfrom
maryannxue wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
cc @cloud-fan |
|
Test build #110484 has finished for PR 25764 at commit
|
cloud-fan
reviewed
Sep 12, 2019
| * Returns a sequence containing the subqueries in this plan, also including the (nested) | ||
| * subquries in its children | ||
| */ | ||
| def subqueriesAll(p: SparkPlan): Seq[SparkPlan] = { |
Contributor
There was a problem hiding this comment.
nvm, this consistent with QueryPlan.subqueriesAll
Contributor
|
LGTM |
Contributor
|
thanks, merging to master! |
PavithraRamachandran
pushed a commit
to PavithraRamachandran/spark
that referenced
this pull request
Sep 15, 2019
### What changes were proposed in this pull request? This PR adds a utility class `AdaptiveSparkPlanHelper` which provides methods related to tree traversal of an `AdaptiveSparkPlanExec` plan. Unlike their counterparts in `TreeNode` or `QueryPlan`, these methods traverse down leaf nodes of adaptive plans, i.e., `AdaptiveSparkPlanExec` and `QueryStageExec`. ### Why are the changes needed? This utility class can greatly simplify tree traversal code for adaptive spark plans. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? Refined `AdaptiveQueryExecSuite` with the help of the new utility methods. Closes apache#25764 from maryannxue/aqe-utils. Authored-by: maryannxue <maryannxue@apache.org> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
j-baker
pushed a commit
to palantir/spark
that referenced
this pull request
Jan 25, 2020
This PR adds a utility class `AdaptiveSparkPlanHelper` which provides methods related to tree traversal of an `AdaptiveSparkPlanExec` plan. Unlike their counterparts in `TreeNode` or `QueryPlan`, these methods traverse down leaf nodes of adaptive plans, i.e., `AdaptiveSparkPlanExec` and `QueryStageExec`. This utility class can greatly simplify tree traversal code for adaptive spark plans. No. Refined `AdaptiveQueryExecSuite` with the help of the new utility methods. Closes apache#25764 from maryannxue/aqe-utils. Authored-by: maryannxue <maryannxue@apache.org> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds a utility class
AdaptiveSparkPlanHelperwhich provides methods related to tree traversal of anAdaptiveSparkPlanExecplan. Unlike their counterparts inTreeNodeorQueryPlan, these methods traverse down leaf nodes of adaptive plans, i.e.,AdaptiveSparkPlanExecandQueryStageExec.Why are the changes needed?
This utility class can greatly simplify tree traversal code for adaptive spark plans.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Refined
AdaptiveQueryExecSuitewith the help of the new utility methods.