Skip to content

[SPARK-3722][Docs]minor improvement and fix in docs#2579

Closed
WangTaoTheTonic wants to merge 4 commits intoapache:masterfrom
WangTaoTheTonic:docsWork
Closed

[SPARK-3722][Docs]minor improvement and fix in docs#2579
WangTaoTheTonic wants to merge 4 commits intoapache:masterfrom
WangTaoTheTonic:docsWork

Conversation

@WangTaoTheTonic
Copy link
Contributor

@SparkQA
Copy link

SparkQA commented Sep 29, 2014

QA tests have started for PR 2579 at commit 4ee1a26.

  • This patch merges cleanly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"will be run" is correct here

@SparkQA
Copy link

SparkQA commented Sep 29, 2014

QA tests have finished for PR 2579 at commit 4ee1a26.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20977/

@SparkQA
Copy link

SparkQA commented Sep 29, 2014

QA tests have started for PR 2579 at commit 34cb4ea.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 29, 2014

QA tests have finished for PR 2579 at commit 34cb4ea.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20983/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we want to put a link to a specific version of the hadoop docs. Its a maintenance issue and people use many different versions of Hadoop where there could be slight differences.

@SparkQA
Copy link

SparkQA commented Oct 1, 2014

QA tests have started for PR 2579 at commit 29d22fa.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 1, 2014

QA tests have finished for PR 2579 at commit 29d22fa.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21118/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally prefer not to include these low level specifics but if others find it useful though I'm ok with it. I would rather see the wording changes though. Something more like:

You can also use view the container log files directly in HDFS using the HDFS shell or API. The directory where they are located can be found by looking at your YARN configs (yarn.nodemanager.remote-app-log-dir and yarn.nodemanager.remote-app-log-dir-suffix).

@SparkQA
Copy link

SparkQA commented Nov 7, 2014

Test build #23049 has started for PR 2579 at commit 6f91cec.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Nov 7, 2014

Test build #23049 has finished for PR 2579 at commit 6f91cec.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23049/
Test PASSed.

@tgravescs
Copy link
Contributor

@srowen did you have any further comments?

@srowen
Copy link
Member

srowen commented Nov 7, 2014

LGTM

@WangTaoTheTonic
Copy link
Contributor Author

@tgravescs Is it ok to go?

@tgravescs
Copy link
Contributor

looks good. Thanks!

@asfgit asfgit closed this in e421072 Nov 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants