[SPARK-28208][SQL][FOLLOWUP] Use tryWithResource pattern#25842
Closed
dongjoon-hyun wants to merge 3 commits intoapache:masterfrom
dongjoon-hyun:SPARK-28208
Closed
[SPARK-28208][SQL][FOLLOWUP] Use tryWithResource pattern#25842dongjoon-hyun wants to merge 3 commits intoapache:masterfrom dongjoon-hyun:SPARK-28208
tryWithResource pattern#25842dongjoon-hyun wants to merge 3 commits intoapache:masterfrom
dongjoon-hyun:SPARK-28208
Conversation
Member
Author
|
@HyukjinKwon , according to your advice, I tried to replace two more instances. |
Member
Author
|
Thank you for review. I transformed the test cases, too. |
|
Test build #110963 has finished for PR 25842 at commit
|
|
Test build #110970 has finished for PR 25842 at commit
|
Member
Author
|
Retest this please. |
|
Test build #110981 has finished for PR 25842 at commit
|
srowen
reviewed
Sep 19, 2019
| val requestedColIdsOrEmptyFile = OrcUtils.requestedColumnIds( | ||
| isCaseSensitive, dataSchema, requiredSchema, reader, conf) | ||
| reader.close() | ||
| val requestedColIdsOrEmptyFile = { |
Member
There was a problem hiding this comment.
Nit: The outer braces are redundant here
|
Test build #111016 has finished for PR 25842 at commit
|
Member
Author
|
Thank you, @HyukjinKwon , @srowen , @HeartSaVioR . Merged to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to use
tryWithResourcefor ORC file.Why are the changes needed?
This is a follow-up to address #25006 (comment) .
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the Jenkins with the existing tests.