[MINOR][BUILD] Fix about 15 misc build warnings#25852
[MINOR][BUILD] Fix about 15 misc build warnings#25852srowen wants to merge 3 commits intoapache:masterfrom
Conversation
|
Test build #110995 has finished for PR 25852 at commit
|
|
|
||
| implicit val webDriver: WebDriver = | ||
| new HtmlUnitDriver(BrowserVersion.INTERNET_EXPLORER_11, true) | ||
| new HtmlUnitDriver(BrowserVersion.INTERNET_EXPLORER, true) |
There was a problem hiding this comment.
Just wondering why Internet Explorer at all. Why not BrowserVersion.getDefault()?
There was a problem hiding this comment.
#24843 (comment) is relevant, but, I imagine any modern browser would handle the jquery JS fine too. I can try just removing this specification, as it (now) defaults to Chrome (51). I think before it emulated IE 8.
|
Test build #111006 has finished for PR 25852 at commit
|
|
Test build #111004 has finished for PR 25852 at commit
|
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM (Pending Jenkins).
|
Test build #4878 has finished for PR 25852 at commit
|
|
Some of them looks relevant to |
This addresses about 15 miscellaneous warnings that appear in the current build. No functional changes, it just slightly reduces the amount of extra warning output. No. Existing tests, run manually. Closes apache#25852 from srowen/BuildWarnings. Authored-by: Sean Owen <sean.owen@databricks.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
|
Sure, only a handful affected 2.4: #25857 |
4 participants
What changes were proposed in this pull request?
This addresses about 15 miscellaneous warnings that appear in the current build.
Why are the changes needed?
No functional changes, it just slightly reduces the amount of extra warning output.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests, run manually.