[SPARK-29255][SQL][TESTS] Rename package pgSQL to postgreSQL#25936
Closed
gengliangwang wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-29255][SQL][TESTS] Rename package pgSQL to postgreSQL#25936gengliangwang wants to merge 2 commits intoapache:masterfrom
gengliangwang wants to merge 2 commits intoapache:masterfrom
Conversation
Member
|
Looks ok to me. also cc: @dongjoon-hyun @HyukjinKwon |
wangyum
approved these changes
Sep 26, 2019
|
Test build #111397 has finished for PR 25936 at commit
|
Member
Author
|
retest this please. |
Member
|
@gengliangwang . Could you handle the followings together? |
dongjoon-hyun
approved these changes
Sep 26, 2019
HyukjinKwon
approved these changes
Sep 26, 2019
Member
HyukjinKwon
left a comment
There was a problem hiding this comment.
LGTM too except @dongjoon-hyun's comments
Member
Author
|
@dongjoon-hyun Thanks for the suggestion. |
|
Test build #111399 has finished for PR 25936 at commit
|
|
Test build #111412 has finished for PR 25936 at commit
|
Member
|
Merged to master. |
Member
|
Thank you all! |
Member
|
Thanks, @gengliangwang ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Rename the package pgSQL to postgreSQL
Why are the changes needed?
To address the comment in #25697 (comment) . The official full name seems more reasonable.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing unit tests.