[SPARK-29258][ML][PYSPARK] parity between ml.evaluator and mllib.metrics#25940
Closed
zhengruifeng wants to merge 5 commits intoapache:masterfrom
Closed
[SPARK-29258][ML][PYSPARK] parity between ml.evaluator and mllib.metrics#25940zhengruifeng wants to merge 5 commits intoapache:masterfrom
zhengruifeng wants to merge 5 commits intoapache:masterfrom
Conversation
|
Test build #111411 has finished for PR 25940 at commit
|
|
Test build #111422 has finished for PR 25940 at commit
|
|
Test build #111424 has finished for PR 25940 at commit
|
srowen
approved these changes
Sep 26, 2019
| case "mse" => false | ||
| case "r2" => true | ||
| case "mae" => false | ||
| case "var" => true |
Member
There was a problem hiding this comment.
Total nit, but you could write case "r2" | "var" => true
|
Test build #111459 has finished for PR 25940 at commit
|
Contributor
Author
|
Merged to master. Thanks @srowen for reviewing |
Closed
47 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
1, expose
BinaryClassificationMetrics.numBinsinBinaryClassificationEvaluator2, expose
RegressionMetrics.throughOrigininRegressionEvaluator3, add metric
explainedVarianceinRegressionEvaluatorWhy are the changes needed?
existing function in mllib.metrics should also be exposed in ml
Does this PR introduce any user-facing change?
yes, this PR add two expert params and one metric option
How was this patch tested?
existing and added tests