Skip to content

[SPARK-29404][DOCS] Add an explanation about the executor color changed in WebUI documentation#26065

Closed
TomokoKomiyama wants to merge 4 commits intoapache:masterfrom
TomokoKomiyama:add-doc
Closed

[SPARK-29404][DOCS] Add an explanation about the executor color changed in WebUI documentation#26065
TomokoKomiyama wants to merge 4 commits intoapache:masterfrom
TomokoKomiyama:add-doc

Conversation

@TomokoKomiyama
Copy link
Contributor

@TomokoKomiyama TomokoKomiyama commented Oct 9, 2019

What changes were proposed in this pull request?

Add an explanation about changing the color darker on an executor bar.

↓ Add this explanation
docs

Why are the changes needed?

Documentation doesn't explain enough about why the executor bar's color changes with click on it on Web UI.

Does this PR introduce any user-facing change?

Yes.

How was this patch tested?

Manually test.

@TomokoKomiyama TomokoKomiyama changed the title [SPARK-29404][DOCS] Add an explanation about the executor color changed in sql documentation [SPARK-29404][DOCS] Add an explanation about the executor color changed in WebUI documentation Oct 9, 2019
@TomokoKomiyama
Copy link
Contributor Author

TomokoKomiyama commented Oct 9, 2019

I trimmed docs/img/AllJobsPageDetail2.png to narrow the margin(space).

[ Before ]
webui-before

[ After ]
webui-after

</p>

* Details of jobs grouped by status: Displays detailed information of the jobs including Job ID, description (with a link to detailed job page), submitted time, duration, stages summary and tasks progress bar
When you click on a executor, you can make the color darker to point it at.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this means what you intend.
I also don't think this is necessary to write into docs.
The image updates are then not necessary.
I'd close this one, personally.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Users may be confused because of the meaning of executor bar color changes with clicking is not obvious.
I think this explanation works to show that the color changes is not bug, and to make user know the function which is just point up the bar.

Do you have any better ideas to help users understand this non-obvious behavior?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I just don't think it's meaningful enough to try to explain, and the new text above is incorrect too.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@srowen srowen closed this Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments