[SPARK-29381][FOLLOWUP][PYTHON][ML] Add 'private' _XXXParams classes for classification & regression#26142
[SPARK-29381][FOLLOWUP][PYTHON][ML] Add 'private' _XXXParams classes for classification & regression#26142huaxingao wants to merge 1 commit intoapache:masterfrom
Conversation
| """ | ||
| self._set(thresholds=value) | ||
| self._clear(self.threshold) | ||
| return self |
There was a problem hiding this comment.
it's a little strange to have setThreshold/Thresholds in the XXXParams class, but scala LogisticRegressionParams does this way, so I just do the same to be consistent with scala side.
srowen
left a comment
There was a problem hiding this comment.
Are there any actual changes to the API or it's just moving definitions around?
|
Test build #112181 has finished for PR 26142 at commit
|
|
@srowen This PR should add above-mentioned methods. (Some of them are redundant setters, we will remove in following PR) @huaxingao some conflicts happened |
|
@srowen sorry, I somehow didn't see your comment. As @zhengruifeng mentioned, this PR adds setters/getters in @zhengruifeng I will rebase and resolve the conflict. |
…for classification & regression
30c4b24 to
cdf87c7
Compare
|
Test build #112253 has finished for PR 26142 at commit
|
|
merged to master, thanks all |
|
Thanks! @zhengruifeng @srowen |
What changes were proposed in this pull request?
Add private _XXXParams classes for classification & regression
Why are the changes needed?
To keep parity between scala and python
Does this PR introduce any user-facing change?
Yes. Add gettters/setters for the following Model classes
How was this patch tested?
Add a few doctest