Rectify gereneric parameter names between SparkContext and AccumulablePa...#2637
Closed
nkronenfeld wants to merge 1 commit intoapache:masterfrom
nkronenfeld:accumulators
Closed
Rectify gereneric parameter names between SparkContext and AccumulablePa...#2637nkronenfeld wants to merge 1 commit intoapache:masterfrom nkronenfeld:accumulators
nkronenfeld wants to merge 1 commit intoapache:masterfrom
nkronenfeld:accumulators
Conversation
|
QA tests have started for PR 2637 at commit
|
|
QA tests have finished for PR 2637 at commit
|
|
Test PASSed. |
Member
|
+1, makes more sense for sure. Open a JIRA for this as well? |
Contributor
Author
Contributor
|
Thanks @nkronenfeld and @srowen. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AccumulableParam gave its generic parameters as 'R, T', whereas SparkContext labeled them 'T, R'.
Trivial, but really confusing.
I resolved this in favor of AccumulableParam, because it seemed to have some logic for its names. I also extended this minimal, but at least present, justification into the SparkContext comments.