[SPARK-29725][SQL][TESTS] Add ThriftServerPageSuite#26403
Closed
shahidki31 wants to merge 4 commits intoapache:masterfrom
Closed
[SPARK-29725][SQL][TESTS] Add ThriftServerPageSuite#26403shahidki31 wants to merge 4 commits intoapache:masterfrom
shahidki31 wants to merge 4 commits intoapache:masterfrom
Conversation
1bc233c to
e420857
Compare
|
Test build #113280 has finished for PR 26403 at commit
|
|
Test build #113281 has finished for PR 26403 at commit
|
Contributor
Author
|
retest this please |
Contributor
Author
|
cc @srowen Kindly review |
srowen
requested changes
Nov 5, 2019
...tserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerPageSuite.scala
Outdated
Show resolved
Hide resolved
...tserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerPageSuite.scala
Outdated
Show resolved
Hide resolved
...tserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerPageSuite.scala
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thanks @srowen for the review |
|
Test build #113285 has finished for PR 26403 at commit
|
srowen
approved these changes
Nov 6, 2019
|
Test build #113288 has finished for PR 26403 at commit
|
HyukjinKwon
approved these changes
Nov 6, 2019
Member
|
Merged to master. |
Contributor
Author
|
Thanks @HyukjinKwon @srowen |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added UT for the classes
ThriftServerPage.scalaandThriftServerSessionPage.scalaWhy are the changes needed?
Currently, there are no UTs for testing Thriftserver UI page
Does this PR introduce any user-facing change?
No
How was this patch tested?
UT