Skip to content

[SPARK-29725][SQL][TESTS] Add ThriftServerPageSuite#26403

Closed
shahidki31 wants to merge 4 commits intoapache:masterfrom
shahidki31:ut
Closed

[SPARK-29725][SQL][TESTS] Add ThriftServerPageSuite#26403
shahidki31 wants to merge 4 commits intoapache:masterfrom
shahidki31:ut

Conversation

@shahidki31
Copy link
Contributor

What changes were proposed in this pull request?

Added UT for the classes ThriftServerPage.scala and ThriftServerSessionPage.scala

Why are the changes needed?

Currently, there are no UTs for testing Thriftserver UI page

Does this PR introduce any user-facing change?

No

How was this patch tested?

UT

@shahidki31 shahidki31 force-pushed the ut branch 2 times, most recently from 1bc233c to e420857 Compare November 5, 2019 18:25
@SparkQA
Copy link

SparkQA commented Nov 5, 2019

Test build #113280 has finished for PR 26403 at commit e0407d6.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • .doc(\"Comma-separated list of class names implementing \" +
  • sealed abstract class PluginContainer
  • class PluginMetricsSource(
  • case class PluginMessage(pluginName: String, message: AnyRef)
  • public class GangliaReporter extends ScheduledReporter
  • public static class Builder
  • abstract class IntervalNumOperation(
  • case class MultiplyInterval(interval: Expression, num: Expression)
  • case class DivideInterval(interval: Expression, num: Expression)
  • case class AlterTableAddPartitionStatement(
  • case class AlterTableSerDePropertiesStatement(
  • case class ShowCurrentNamespaceStatement() extends ParsedStatement
  • case class ShowCurrentNamespace(catalogManager: CatalogManager) extends Command
  • case class ShowCurrentNamespaceExec(

@SparkQA
Copy link

SparkQA commented Nov 5, 2019

Test build #113281 has finished for PR 26403 at commit e420857.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@shahidki31
Copy link
Contributor Author

retest this please

@shahidki31
Copy link
Contributor Author

cc @srowen Kindly review

@shahidki31
Copy link
Contributor Author

Thanks @srowen for the review

@SparkQA
Copy link

SparkQA commented Nov 5, 2019

Test build #113285 has finished for PR 26403 at commit e420857.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-29725][Tests]Add UT for Thriftserver page [SPARK-29725][SQL][TESTS] Add ThriftServerPageSuite Nov 6, 2019
@SparkQA
Copy link

SparkQA commented Nov 6, 2019

Test build #113288 has finished for PR 26403 at commit d085611.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

Merged to master.

@shahidki31
Copy link
Contributor Author

Thanks @HyukjinKwon @srowen

@shahidki31 shahidki31 deleted the ut branch November 6, 2019 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants