[SPARK-29821][SQL] Allow calling non-aggregate SQL functions with column name #26435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Member
|
Can you file jira first and add a JIRA ID in the title? see: https://spark.apache.org/contributing.html |
MaxHaertwig
changed the title
HyukjinKwon
reviewed
Nov 11, 2019
| [Row(r1=False, r2=False), Row(r1=True, r2=True)] | ||
| """ | ||
| sc = SparkContext._active_spark_context | ||
| if type(col) is str: |
Member
There was a problem hiding this comment.
This seems already working.
Member
There was a problem hiding this comment.
>>> from pyspark.sql.functions import isnan
>>> df = spark.createDataFrame([(1.0, float('nan')), (float('nan'), 2.0)], ("a", "b"))
>>> df.select(isnan("a")).collect()
[Row(isnan(a)=False), Row(isnan(a)=True)]
HyukjinKwon
reviewed
Nov 11, 2019
| * @group normal_funcs | ||
| * @since 1.6.0 | ||
| */ | ||
| def isnan(columnName: String): Column = isnan(Column(columnName)) |
Member
There was a problem hiding this comment.
We won't add this per the comments on the top of this file.
Member
There was a problem hiding this comment.
spark/sql/core/src/main/scala/org/apache/spark/sql/functions.scala
Lines 58 to 60 in f8b1424
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
I added functions that can be called with the column name for the functions in the non-aggregate functions section of
functions.scala.isnan(columnName: String): Columnisnull(columnName: String): Columnnanvl(col1Name: String, col2Name: String): Columnnegate(columnName: String): Columnnot(columnName: String): ColumnbitwiseNOT(columnName: String): ColumnWhy are the changes needed?
This pull requests makes it possible to check for nan values in the column
xby callingisnan("x"), instead ofisnan($"x"). PySpark:isnan("x"), instead ofisnan(col("x")). This way, users don't need to remember to transform the value to a column. This makes it consistent with other functions such assqrtthat can already be called with the column name.Does this PR introduce any user-facing change?
Yes
See previous section.
How was this patch tested?
I couldn't find a test file, where sql functions and pyspark sql functions are tested. Please point me in the right direction.