[SPARK-29820][INFRA][FOLLOWUP][2.4] Use scala version instead of java version #26460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srowen
approved these changes
Nov 10, 2019
Member
Author
|
Sorry, @srowen . During backporting, I missed this. My bad. Thank you for swift review and approval. |
Member
Author
|
This is only related to GitHub Actions and it's passed with all combination with the correct log. Merged to branch-2.4. |
dongjoon-hyun
added a commit
that referenced
this pull request
Nov 10, 2019
… version ### What changes were proposed in this pull request? This is a followup to fix the cache key to use `scala` version instead of `java` version in `branch-2.4`. ### Why are the changes needed? In `branch-2.4`, we have different build combinations. **Before** ``` Cache not found for input keys: -hadoop-2.6-maven-com-73f091c178d11734dd9a888d0c5d208d72850eefd9db3821d806518289c61371, -hadoop-2.6-maven-com-. ``` **After** ``` Cache not found for input keys: 2.11-hadoop-2.6-maven-com-73f091c178d11734dd9a888d0c5d208d72850eefd9db3821d806518289c61371, 2.11-hadoop-2.6-maven-com-. ``` ### Does this PR introduce any user-facing change? No. ### How was this patch tested? Manually check the log of GitHub Action of this PR. Closes #26460 from dongjoon-hyun/SPARK-29820-2. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
|
Test build #113548 has finished for PR 26460 at commit
|
scunniff
pushed a commit
to scunniff/nomad-spark
that referenced
this pull request
Nov 10, 2020
… version ### What changes were proposed in this pull request? This is a followup to fix the cache key to use `scala` version instead of `java` version in `branch-2.4`. ### Why are the changes needed? In `branch-2.4`, we have different build combinations. **Before** ``` Cache not found for input keys: -hadoop-2.6-maven-com-73f091c178d11734dd9a888d0c5d208d72850eefd9db3821d806518289c61371, -hadoop-2.6-maven-com-. ``` **After** ``` Cache not found for input keys: 2.11-hadoop-2.6-maven-com-73f091c178d11734dd9a888d0c5d208d72850eefd9db3821d806518289c61371, 2.11-hadoop-2.6-maven-com-. ``` ### Does this PR introduce any user-facing change? No. ### How was this patch tested? Manually check the log of GitHub Action of this PR. Closes apache#26460 from dongjoon-hyun/SPARK-29820-2. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a followup to fix the cache key to use
scalaversion instead ofjavaversion inbranch-2.4.Why are the changes needed?
In
branch-2.4, we have different build combinations.Before
After
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manually check the log of GitHub Action of this PR.