[SPARK-29866][SQL][SS][ML] Upper case enum values#26487
Closed
MaxGekk wants to merge 19 commits intoapache:masterfrom
Closed
[SPARK-29866][SQL][SS][ML] Upper case enum values#26487MaxGekk wants to merge 19 commits intoapache:masterfrom
MaxGekk wants to merge 19 commits intoapache:masterfrom
Conversation
Member
Author
|
@srowen @dongjoon-hyun Could you review this PR, please. |
|
Test build #113646 has finished for PR 26487 at commit
|
srowen
reviewed
Nov 12, 2019
Member
srowen
left a comment
srowen
left a comment
There was a problem hiding this comment.
Although I'd like a suggested standard, I don't think this is worth changing retroactively, especially where it's user-visible. Scala enums seem to use CamelCase. Java enums use ALL_CAPS mostly for parity with the 'constants' naming convention, even though they act a little more like class instances.
Member
|
I also agree with @srowen . This is not worth of changing the existing code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to rename enum values and upper case them for unification.
Why are the changes needed?
To follow common approach and unify naming of enum values.
Does this PR introduce any user-facing change?
No
How was this patch tested?
By existing tests