[SPARK-3793][SQL]use HiveConf/Context when parse hive ql#2655
Closed
scwf wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-3793][SQL]use HiveConf/Context when parse hive ql#2655scwf wants to merge 1 commit intoapache:masterfrom
scwf wants to merge 1 commit intoapache:masterfrom
Conversation
|
Can one of the admins verify this patch? |
scwf
changed the title
Contributor
Author
|
It should be fixed in #2241, so close this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to make hive ql parser more general and compatible with both hive-0.12 and hive-0.13. In hive-0.13 we may need hiveconf(Context) when parsing a sql(quoted sql). For example, runing sql as follow without hiveconf will get NPE exception:
createQueryTest("quoted alias.attr",
"SELECT
a.keyFROM src a ORDER BY key LIMIT 1")[info] - quoted alias.attr *** FAILED ***
[info] org.apache.spark.sql.hive.HiveQl$ParseException: Failed to parse: SELECT
a.keyFROM src a ORDER BY key LIMIT 1[info] at org.apache.spark.sql.hive.HiveQl$.parseSql(HiveQl.scala:221)
[info] at org.apache.spark.sql.hive.test.TestHiveContext$HiveQLQueryExecution.logical$lzycompute(TestHive.scala:143)
[info] at org.apache.spark.sql.hive.test.TestHiveContext$HiveQLQueryExecution.logical(TestHive.scala:143)
[info] at org.apache.spark.sql.hive.test.TestHiveContext$QueryExecution.analyzed$lzycompute(TestHive.scala:153)
[info] at org.apache.spark.sql.hive.test.TestHiveContext$QueryExecution.analyzed(TestHive.scala:152)
[info] at org.apache.spark.sql.SQLContext$QueryExecution.optimizedPlan$lzycompute(SQLContext.scala:403)
[info] at org.apache.spark.sql.SQLContext$QueryExecution.optimizedPlan(SQLContext.scala:403)
[info] at org.apache.spark.sql.SQLContext$QueryExecution.sparkPlan$lzycompute(SQLContext.scala:407)
[info] at org.apache.spark.sql.SQLContext$QueryExecution.sparkPlan(SQLContext.scala:405)
[info] at org.apache.spark.sql.SQLContext$QueryExecution.executedPlan$lzycompute(SQLContext.scala:411)
[info] ...
[info] Cause: java.lang.NullPointerException:
[info] at org.apache.hadoop.hive.conf.HiveConf.getVar(HiveConf.java:1295)
[info] at org.apache.hadoop.hive.ql.parse.HiveLexer.allowQuotedId(HiveLexer.java:342)
[info] at org.apache.hadoop.hive.ql.parse.HiveLexer$DFA21.specialStateTransition(HiveLexer.java:10945)
[info] at org.antlr.runtime.DFA.predict(DFA.java:80)
[info] at org.apache.hadoop.hive.ql.parse.HiveLexer.mIdentifier(HiveLexer.java:7925)
[info] at org.apache.hadoop.hive.ql.parse.HiveLexer.mTokens(HiveLexer.java:10818)
[info] at org.antlr.runtime.Lexer.nextToken(Lexer.java:89)
[info] at org.antlr.runtime.BufferedTokenStream.fetch(BufferedTokenStream.java:133)
[info] at org.antlr.runtime.BufferedTokenStream.sync(BufferedTokenStream.java:127)
[info] at org.antlr.runtime.CommonTokenStream.consume(CommonTokenStream.java:70)