[SPARK-29911][SQL][FOLLOWUP] Move related unit test to ThriftServerWithSparkContextSuite#26628
Closed
LantaoJin wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-29911][SQL][FOLLOWUP] Move related unit test to ThriftServerWithSparkContextSuite#26628LantaoJin wants to merge 1 commit intoapache:masterfrom
LantaoJin wants to merge 1 commit intoapache:masterfrom
Conversation
…thSparkContextSuite
Contributor
Author
|
Test build #114245 has finished for PR 26628 at commit
|
| import org.apache.spark.sql.QueryTest | ||
| import org.apache.spark.sql.test.SharedSparkSession | ||
|
|
||
| class ThriftServerWithSparkContextSuite extends QueryTest with SharedSparkSession { |
Member
There was a problem hiding this comment.
Do we need to have a new test suite? Originally, I suggested somewhere in HiveThriftServer2Suites.scala. Was it improper for this?
Member
There was a problem hiding this comment.
I'm just curious about the blocker you hit at that time, @LantaoJin .
Member
There was a problem hiding this comment.
This is because we can't get the SparkContext from HiveThriftServer2Suites.
HyukjinKwon
approved these changes
Nov 22, 2019
Member
|
Merged to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is follow up of #26543
See #26543 (comment)
Does this PR introduce any user-facing change?
No
How was this patch tested?
Exist UT.