Skip to content

[SPARK-30186][SQL] support Dynamic Partition Pruning in Adaptive Execution#26814

Closed
chrysan wants to merge 1 commit intoapache:masterfrom
chrysan:SPARK-30186
Closed

[SPARK-30186][SQL] support Dynamic Partition Pruning in Adaptive Execution#26814
chrysan wants to merge 1 commit intoapache:masterfrom
chrysan:SPARK-30186

Conversation

@chrysan
Copy link
Contributor

@chrysan chrysan commented Dec 9, 2019

What changes were proposed in this pull request?

To support queries with dynamic partition pruning subqueries work in adaptive query execution.

Why are the changes needed?

Queries' performance can benefit from AE and DPP at the same time.

Does this PR introduce any user-facing change?

NO

How was this patch tested?

Test cases are added.

@wangyum
Copy link
Member

wangyum commented Dec 9, 2019

ok to test

@SparkQA
Copy link

SparkQA commented Dec 9, 2019

Test build #115039 has finished for PR 26814 at commit f39cc6a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • case class InsertAdaptiveSparkPlan(

@HyukjinKwon
Copy link
Member

@maryannxue FYI

@wangyum
Copy link
Member

wangyum commented Dec 12, 2019

Also cc @cloud-fan

@maryannxue
Copy link
Contributor

The plan is due to change over the entire process of query execution, so planning the dynamic filters for the whole plan in each re-optimization iteration is definitely the least efficient way. A join can swing from a SMJ to a BHJ or the other way around from time to time, and that affects the applicability of a SubqueryBroadcast DPP filter, and you may end up changing and replanning the filter back and forth.

@chrysan
Copy link
Contributor Author

chrysan commented Dec 13, 2019

The plan is due to change over the entire process of query execution, so planning the dynamic filters for the whole plan in each re-optimization iteration is definitely the least efficient way. A join can swing from a SMJ to a BHJ or the other way around from time to time, and that affects the applicability of a SubqueryBroadcast DPP filter, and you may end up changing and replanning the filter back and forth.

Agree with your concern. But in our real production cases, the re-planning effort in AE is worth if DPP can benefit the pruning a lot. I think we can add a switch to let users turn DPP on in AE.

@github-actions
Copy link

We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!

@github-actions github-actions bot added the Stale label Mar 23, 2020
@github-actions github-actions bot closed this Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants