[WIP][SPARK-30203][SQL] store assignable if there is an appropriate user-defined cast function#26833
Closed
yaooqinn wants to merge 1 commit intoapache:masterfrom
yaooqinn:SPARK-30203
Closed
[WIP][SPARK-30203][SQL] store assignable if there is an appropriate user-defined cast function#26833yaooqinn wants to merge 1 commit intoapache:masterfrom yaooqinn:SPARK-30203
yaooqinn wants to merge 1 commit intoapache:masterfrom
yaooqinn:SPARK-30203
Conversation
…efined cast function
Member
Author
|
cc @cloud-fan @maropu @HyukjinKwon @gengliangwang @gatorsmile @dongjoon-hyun, IIUC, the current implementation for store assignment might go wrong with ANSI's context. |
|
Test build #115103 has finished for PR 26833 at commit
|
Member
|
@yaooqinn I think the store assignment rule is independent of the casting rule.
IIUC, there is no UDCF support in Spark. |
Member
Author
|
I got it. thanks. @gengliangwang |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
9.2 Store assignment
Syntax Rules
4.11 Data conversions
The current implementation for ANSI store assignment is totally out of context.
According to this rule,
there shall exist an appropriate user-defined cast function UDCF, the spark legacy store assignment is just fine because we do have appropriate cast functions.At least according to the ansi cast rule, the current ANSI assignment policy is too strict to the ANSI cast rules
Why are the changes needed?
the current ansi store assignment rule is not ansi.
Does this PR introduce any user-facing change?
yes, pending
How was this patch tested?
add uts.