[SPARK-30040][SQL] DROP FUNCTION should do multi-catalog resolution#26854
Closed
planga82 wants to merge 3 commits intoapache:masterfrom
Closed
[SPARK-30040][SQL] DROP FUNCTION should do multi-catalog resolution#26854planga82 wants to merge 3 commits intoapache:masterfrom
planga82 wants to merge 3 commits intoapache:masterfrom
Conversation
Contributor
Author
imback82
reviewed
Dec 12, 2019
| ShowFunctionsCommand(database, function, userScope, systemScope) | ||
|
|
||
| case DropFunctionStatement( | ||
| CatalogAndIdentifier(catalog, functionIdent), ifExists, isTemp) => |
Contributor
There was a problem hiding this comment.
nit: This can go to the previous line.
case DropFunctionStatement(CatalogAndIdentifier(catalog, functionIdent), ifExists, isTemp) =>
Member
|
ok to test |
|
Test build #115201 has finished for PR 26854 at commit
|
cloud-fan
approved these changes
Dec 12, 2019
|
Test build #115215 has finished for PR 26854 at commit
|
| } | ||
|
|
||
| /** | ||
| * Create a [[DropFunctionCommand]] statement. |
Member
There was a problem hiding this comment.
DropFunctionCommand -> DropFunctionStatement?
Member
There was a problem hiding this comment.
Create a plan for a DROP FUNCTION statement. will be better here.
| ShowFunctionsCommand(database, function, userScope, systemScope) | ||
|
|
||
| case DropFunctionStatement(CatalogAndIdentifier(catalog, functionIdent), ifExists, isTemp) => | ||
| if (isSessionCatalog(catalog)) { |
Member
There was a problem hiding this comment.
indentation from 508 to 518.
imback82
approved these changes
Dec 12, 2019
Contributor
imback82
left a comment
imback82
left a comment
There was a problem hiding this comment.
LGTM (once @dongjoon-hyun's comments are resolved)
viirya
approved these changes
Dec 12, 2019
Member
There was a problem hiding this comment.
Looks good after resolving @dongjoon-hyun's comments and few style comments.
viirya
reviewed
Dec 12, 2019
sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala
Outdated
Show resolved
Hide resolved
viirya
reviewed
Dec 12, 2019
sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala
Outdated
Show resolved
Hide resolved
viirya
reviewed
Dec 12, 2019
sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala
Outdated
Show resolved
Hide resolved
Member
|
Merged to master. |
|
Test build #115252 has finished for PR 26854 at commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add DropFunctionStatement and make DROP FUNCTION go through the same catalog/table resolution framework of v2 commands.
Why are the changes needed?
It's important to make all the commands have the same table resolution behavior, to avoid confusing
DROP FUNCTION namespace.function
Does this PR introduce any user-facing change?
Yes. When running DROP FUNCTION namespace.function Spark fails the command if the current catalog is set to a v2 catalog.
How was this patch tested?
Unit tests.