[SPARK-30104][SQL][FOLLOWUP] Remove LookupCatalog.AsTemporaryViewIdentifier#26897
Closed
imback82 wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-30104][SQL][FOLLOWUP] Remove LookupCatalog.AsTemporaryViewIdentifier#26897imback82 wants to merge 1 commit intoapache:masterfrom
imback82 wants to merge 1 commit intoapache:masterfrom
Conversation
Member
There was a problem hiding this comment.
@imback82 . I know the discussion, but I want to double-check if there is no test coverage loss.
Also, since this is a removal of the existing test code, could you update the PR description more properly? (The following looks too simple.)
Existing tests
|
Test build #115344 has finished for PR 26897 at commit
|
Member
|
CC @cloud-fan |
Contributor
|
If something is only being tested but not nothing else, it's dead code. I checked the removed tests and they solely test LGTM, merging to master! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
As discussed in #26741 (comment),
LookupCatalog.AsTemporaryViewIdentifieris no longer used and can be removed.Why are the changes needed?
Code clean up
Does this PR introduce any user-facing change?
No
How was this patch tested?
Removed tests that were testing solely
AsTemporaryViewIdentifierextractor.