[SPARK-30315][SQL] Add adaptive execution context #26959
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryannxue
changed the title
|
Test build #115601 has finished for PR 26959 at commit
|
Contributor
|
retest this please |
cloud-fan
reviewed
Dec 20, 2019
| case class AdaptiveSparkPlanExec( | ||
| initialPlan: SparkPlan, | ||
| @transient session: SparkSession, | ||
| @transient adaptiveExecutionContext: AdaptiveExecutionContext, |
Contributor
There was a problem hiding this comment.
for simplicity, we can just name it context.
|
Test build #115619 has finished for PR 26959 at commit
|
Contributor
|
retest it please |
|
Test build #116282 has finished for PR 26959 at commit
|
Contributor
|
retest this please |
|
Test build #116293 has finished for PR 26959 at commit
|
Contributor
|
retest this please |
|
Test build #116306 has finished for PR 26959 at commit
|
cloud-fan
approved these changes
Jan 8, 2020
|
Test build #116315 has finished for PR 26959 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a minor code refactoring PR. It creates an adaptive execution context class to wrap objects shared across main query and sub-queries.
Why are the changes needed?
This refactoring will improve code readability and reduce the number of parameters used to initialize
AdaptiveSparkPlanExec.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Passed existing UTs.