[SPARK-30440][CORE][TESTS] Avoid race condition in TaskSetManagerSuite by not using resourceOffer #27115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
ajithme
changed the title
Ngone51
reviewed
Jan 7, 2020
core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala
Outdated
Show resolved
Hide resolved
srowen
reviewed
Jan 7, 2020
core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Updated with review comments. Please review cc @srowen @Ngone51 @cloud-fan |
Member
|
Jenkins test this please |
|
Test build #116248 has finished for PR 27115 at commit
|
dongjoon-hyun
changed the title
core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@dongjoon-hyun Updated as per comments, Please review |
cloud-fan
reviewed
Jan 8, 2020
cloud-fan
reviewed
Jan 8, 2020
core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Jan 8, 2020
core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala
Outdated
Show resolved
Hide resolved
Use long running task to avoid completion mid test Review Comments Handle review comments
Contributor
Author
|
Updated as per comments. Please review @cloud-fan @dongjoon-hyun @srowen |
cloud-fan
approved these changes
Jan 8, 2020
Ngone51
reviewed
Jan 8, 2020
core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala
Outdated
Show resolved
Hide resolved
Member
|
Retest this please. |
core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala
Outdated
Show resolved
Hide resolved
Member
|
Retest this please |
|
Test build #116319 has finished for PR 27115 at commit
|
|
Test build #116321 has finished for PR 27115 at commit
|
dongjoon-hyun
approved these changes
Jan 9, 2020
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Merged to master.
dongjoon-hyun
changed the title
Contributor
|
Thanks for the quick fix of flaky test! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
There is a race condition in test case introduced in SPARK-30359 between reviveOffers in org.apache.spark.scheduler.TaskSchedulerImpl#submitTasks and org.apache.spark.scheduler.TaskSetManager#resourceOffer, in the testcase
No need to do resourceOffers as submitTask will revive offers from task set
Why are the changes needed?
Fix flaky test
Does this PR introduce any user-facing change?
No
How was this patch tested?
Test case can pass after the change