[SPARK-30504][PYTHON][ML] Set weightCol in OneVsRest(Model) _to_java and _from_java#27190
Closed
zero323 wants to merge 4 commits intoapache:masterfrom
Closed
[SPARK-30504][PYTHON][ML] Set weightCol in OneVsRest(Model) _to_java and _from_java#27190zero323 wants to merge 4 commits intoapache:masterfrom
zero323 wants to merge 4 commits intoapache:masterfrom
Conversation
|
Test build #116636 has finished for PR 27190 at commit
|
|
Test build #116646 has finished for PR 27190 at commit
|
|
Test build #116648 has finished for PR 27190 at commit
|
Member
|
CC @huaxingao @zhengruifeng as you've been looking at handling weight cols recently |
huaxingao
reviewed
Jan 14, 2020
huaxingao
reviewed
Jan 14, 2020
|
Test build #116726 has finished for PR 27190 at commit
|
Contributor
|
LGTM |
Member
|
Merged to master |
Member
Author
|
Thanks everyone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adjusts
_to_javaand_from_javaofOneVsRestandOneVsRestModelto preserveweightCol.Why are the changes needed?
Currently both
Paramsdon't preserveweightColParamswhen data is saved / loaded:Does this PR introduce any user-facing change?
After this PR is merged, loaded objects will have
weightColParamset.How was this patch tested?