[SPARK-30524] [SQL] follow up SPARK-30524 to resolve comments#27253
Closed
JkSelf wants to merge 4 commits intoapache:masterfrom
Closed
[SPARK-30524] [SQL] follow up SPARK-30524 to resolve comments#27253JkSelf wants to merge 4 commits intoapache:masterfrom
JkSelf wants to merge 4 commits intoapache:masterfrom
Conversation
Author
|
@cloud-fan @maryannxue help to review this PR. Thanks. |
|
Test build #116908 has finished for PR 27253 at commit
|
|
Test build #116910 has finished for PR 27253 at commit
|
cloud-fan
reviewed
Jan 17, 2020
| left: SparkPlan, | ||
| right: SparkPlan) extends BinaryExecNode with CodegenSupport { | ||
| right: SparkPlan, | ||
| partialSMJ: Option[Boolean] = None) extends BinaryExecNode with CodegenSupport { |
Contributor
There was a problem hiding this comment.
nit: isPartial: Boolean = false
cloud-fan
reviewed
Jan 17, 2020
| PartialShuffleReaderExec(shuffleStage, skewedPartitions.toSet) | ||
| } | ||
| subJoins += optimizedSmj | ||
| subJoins += optimizedSmj.asInstanceOf[SortMergeJoinExec].copy(partialSMJ = Some(true)) |
Contributor
There was a problem hiding this comment.
the SMJ may not be the root node. Now I think it's better to match SMJ in the plan transformation above.
cloud-fan
reviewed
Jan 17, 2020
| @@ -222,6 +203,8 @@ case class OptimizeSkewedJoin(conf: SQLConf) extends Rule[SparkPlan] { | |||
| case shuffleStage: ShuffleQueryStageExec if shuffleStage.id == left.id || | |||
Contributor
There was a problem hiding this comment.
sorry I was totally wrong. We are updating the smj here, why not just
val optimizedSmj = smj.copy(
left = s1.copy(child = PartialShuffleReaderExec(left, skewedPartitions.toSet)),
right = s2.copy(child = PartialShuffleReaderExec(right, skewedPartitions.toSet)),
isPartial = true)
cloud-fan
approved these changes
Jan 17, 2020
Contributor
cloud-fan
left a comment
cloud-fan
left a comment
There was a problem hiding this comment.
LGTM except one comment
|
Test build #116932 has finished for PR 27253 at commit
|
|
Test build #116951 has finished for PR 27253 at commit
|
Author
|
retest this please |
|
Test build #116973 has finished for PR 27253 at commit
|
Contributor
|
thanks, merging to master! |
manuzhang
reviewed
Jan 20, 2020
| @@ -247,9 +225,9 @@ case class OptimizeSkewedJoin(conf: SQLConf) extends Rule[SparkPlan] { | |||
| if (shuffleStages.length == 2) { | |||
| // When multi table join, there will be too many complex combination to consider. | |||
| // Currently we only handle 2 table join like following two use cases. | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Resolve the remaining comments in PR#27226.
Why are the changes needed?
Resolve the comments.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing unit tests.