[SPARK-30600][SQL] Migrate ALTER VIEW SET/UNSET commands to the new framework#27314
Closed
imback82 wants to merge 3 commits intoapache:masterfrom
Closed
[SPARK-30600][SQL] Migrate ALTER VIEW SET/UNSET commands to the new framework#27314imback82 wants to merge 3 commits intoapache:masterfrom
imback82 wants to merge 3 commits intoapache:masterfrom
Conversation
|
Test build #117204 has finished for PR 27314 at commit
|
|
Test build #117202 has finished for PR 27314 at commit
|
Contributor
Author
|
cc @cloud-fan |
cloud-fan
reviewed
Jan 22, 2020
| val cleanedTableProperties = cleanTableProperties(ctx, properties) | ||
| if (ctx.VIEW != null) { | ||
| AlterViewSetPropertiesStatement(identifier, cleanedTableProperties) | ||
| AlterTableSetProperties(UnresolvedView(identifier), cleanedTableProperties) |
Contributor
There was a problem hiding this comment.
shouldn't we use AlterViewSetProperties?
cloud-fan
reviewed
Jan 22, 2020
| val ifExists = ctx.EXISTS != null | ||
| if (ctx.VIEW != null) { | ||
| AlterViewUnsetPropertiesStatement(identifier, cleanedProperties, ifExists) | ||
| AlterTableUnsetProperties(UnresolvedView(identifier), cleanedProperties, ifExists) |
Contributor
|
I think we shouldn't reuse the |
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Use the new framework to resolve the ALTER VIEW SET/UNSET TBLPROPERTIES commands.
This PR also introduces
UnresolvedViewandUnresolvedViewWithTableExiststo the framework to handle commands with views.Why are the changes needed?
This is a part of effort to make the relation lookup behavior consistent: SPARK-29900.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Added new tests.