[SPARK-30674][INFRA] Use python3 in dev/lint-python#27394
Closed
dongjoon-hyun wants to merge 2 commits intoapache:masterfrom
dongjoon-hyun:SPARK-30674
Closed
[SPARK-30674][INFRA] Use python3 in dev/lint-python#27394dongjoon-hyun wants to merge 2 commits intoapache:masterfrom dongjoon-hyun:SPARK-30674
dongjoon-hyun wants to merge 2 commits intoapache:masterfrom
dongjoon-hyun:SPARK-30674
Conversation
Member
Author
|
Hi, @HyukjinKwon . How do you think about this? |
Member
Author
|
Also, cc @viirya . Could you review this PR? |
Member
|
hmm, so we currently fail to run |
Member
Author
|
No~ Jenkins is using |
viirya
approved these changes
Jan 30, 2020
viirya
reviewed
Jan 30, 2020
HyukjinKwon
approved these changes
Jan 30, 2020
|
Test build #117546 has finished for PR 27394 at commit
|
|
Test build #117548 has finished for PR 27394 at commit
|
Member
Author
|
Thank you, @HyukjinKwon and @viirya . |
Member
Author
|
Retest this please |
|
Test build #117552 has finished for PR 27394 at commit
|
Member
Author
|
Merged to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to use
python3instead ofpythonindev/lint-python.Why are the changes needed?
Currently,
dev/lint-pythonfails at Python 2. And, Python 2 is EOL since January 1st 2020.Does this PR introduce any user-facing change?
No. This is a dev environment.
How was this patch tested?
Jenkins is running this with Python 3 already.
The following is a manual test.