Skip to content

[SPARK-30674][INFRA] Use python3 in dev/lint-python#27394

Closed
dongjoon-hyun wants to merge 2 commits intoapache:masterfrom
dongjoon-hyun:SPARK-30674
Closed

[SPARK-30674][INFRA] Use python3 in dev/lint-python#27394
dongjoon-hyun wants to merge 2 commits intoapache:masterfrom
dongjoon-hyun:SPARK-30674

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Jan 30, 2020

What changes were proposed in this pull request?

This PR aims to use python3 instead of python in dev/lint-python.

Why are the changes needed?

Currently, dev/lint-python fails at Python 2. And, Python 2 is EOL since January 1st 2020.

$ python -V
Python 2.7.17

$ dev/lint-python
starting python compilation test...
Python compilation failed with the following errors:
Compiling ./python/setup.py ...
  File "./python/setup.py", line 27
    file=sys.stderr)
        ^
SyntaxError: invalid syntax

Does this PR introduce any user-facing change?

No. This is a dev environment.

How was this patch tested?

Jenkins is running this with Python 3 already.
The following is a manual test.

$ python -V
Python 3.8.0

$ dev/lint-python
starting python compilation test...
python compilation succeeded.

@dongjoon-hyun
Copy link
Member Author

Hi, @HyukjinKwon . How do you think about this?

@dongjoon-hyun
Copy link
Member Author

Also, cc @viirya . Could you review this PR?

@viirya
Copy link
Member

viirya commented Jan 30, 2020

hmm, so we currently fail to run dev/lint-python in Jenkins?

@dongjoon-hyun
Copy link
Member Author

dongjoon-hyun commented Jan 30, 2020

No~ Jenkins is using Python3. So, it's okay for now. This is for the other environments which python is pointing python2.
It's described in the PR description test section.

@SparkQA
Copy link

SparkQA commented Jan 30, 2020

Test build #117546 has finished for PR 27394 at commit 1e2f50a.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 30, 2020

Test build #117548 has finished for PR 27394 at commit 02e08a2.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member Author

Thank you, @HyukjinKwon and @viirya .

@dongjoon-hyun
Copy link
Member Author

Retest this please

@SparkQA
Copy link

SparkQA commented Jan 30, 2020

Test build #117552 has finished for PR 27394 at commit 02e08a2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member Author

Merged to master.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-30674 branch January 30, 2020 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments