[SPARK-31093][SHUFFLE] Fast fail while fetching shuffle data unsuccessfully#27855
Closed
turboFei wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-31093][SHUFFLE] Fast fail while fetching shuffle data unsuccessfully#27855turboFei wants to merge 2 commits intoapache:masterfrom
turboFei wants to merge 2 commits intoapache:masterfrom
Conversation
|
Can one of the admins verify this patch? |
turboFei
force-pushed
the
SPARK-31093-fast-fail-fetch
branch
from
722d426 to
3036bcd
Compare
Ngone51
requested changes
Mar 9, 2020
Comment on lines
269
to
272
| override def onBlockFetchFailure(blockId: String, e: Throwable): Unit = { | ||
| logError(s"Failed to get block(s) from ${req.address.host}:${req.address.port}", e) | ||
| results.put(new FailureFetchResult(BlockId(blockId), infoMap(blockId)._2, address, e)) | ||
| throwFetchFailedException(BlockId(blockId), infoMap(blockId)._2, address, e) | ||
| } |
Member
There was a problem hiding this comment.
onBlockFetchFailure will be called within Netty's thread. Thus, ShuffleBlockFetcherIterator can not catch the exception.
Member
Author
There was a problem hiding this comment.
thanks, have modified the code.
Ngone51
reviewed
Mar 10, 2020
Comment on lines
+639
to
+641
| failureFetchResult.foreach { ffr => | ||
| buf.release() | ||
| throwFetchFailedException(ffr.blockId, ffr.mapIndex, ffr.address, ffr.e) |
Member
There was a problem hiding this comment.
errr...I just feel that this makes things be more complex... I actually think that fail-fast here is not such necessary unless we really have high delay in current way.
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When fetching shuffle data unsuccessfully, we put a FailureFetchResult into results(a linkedBlockingQueue) and wait it to be taken.
Then method throwFetchFailedException() would be invoked.
In fact, we can fast fail the task once fetching shuffle data unsuccessfully.
In this PR, we invoke throwFetchFailedException once fetching shuffle data unsuccessfully.
Why are the changes needed?
It can save the time when fetching shuffle data unsuccessfully.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing UT.