[SPARK-30776][ML][FOLLOWUP] FValue clean up#27922
Closed
zhengruifeng wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-30776][ML][FOLLOWUP] FValue clean up#27922zhengruifeng wants to merge 2 commits intoapache:masterfrom
zhengruifeng wants to merge 2 commits intoapache:masterfrom
Conversation
zhengruifeng
commented
Mar 16, 2020
| test("Test FValue selector: numTopFeatures") { | ||
| val selector = new FValueSelector() | ||
| .setOutputCol("filtered").setSelectorType("numTopFeatures").setNumTopFeatures(1) | ||
| val model = selector.fit(dataset) |
Contributor
Author
There was a problem hiding this comment.
model here is never used, and a model will be fitted in following testSelector
|
Test build #119835 has finished for PR 27922 at commit
|
Contributor
Author
|
retest this please |
Contributor
|
LGTM |
|
Test build #119844 has finished for PR 27922 at commit
|
|
Test build #119850 has finished for PR 27922 at commit
|
srowen
approved these changes
Mar 16, 2020
Contributor
Author
|
Merged to master, thanks all |
sjincho
pushed a commit
to sjincho/spark
that referenced
this pull request
Apr 15, 2020
### What changes were proposed in this pull request? remove unused variables; ### Why are the changes needed? remove unused variables; ### Does this PR introduce any user-facing change? No ### How was this patch tested? existing testsuites Closes apache#27922 from zhengruifeng/test_cleanup. Authored-by: zhengruifeng <ruifengz@foxmail.com> Signed-off-by: zhengruifeng <ruifengz@foxmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
remove unused variables;
Why are the changes needed?
remove unused variables;
Does this PR introduce any user-facing change?
No
How was this patch tested?
existing testsuites