[CORE]codeStyle: uniform ConcurrentHashMap define in StorageLevel.scala with other places#2793
[CORE]codeStyle: uniform ConcurrentHashMap define in StorageLevel.scala with other places#2793liyezhang556520 wants to merge 1 commit intoapache:masterfrom
Conversation
|
QA tests have started for PR 2793 at commit
|
|
This also seems at about the level of too trivial to bother with. It replaces a single fully qualified class name with an import, which doesn't even simplify. |
|
But what about other places use ConcurrentHashMap, seems all of them are using import, should not they be unified? |
|
That's not what the PR does though. How many occurrences are there to change? |
|
Well, only here use a single fully qualified class name, and other places use import. like line 25 in SortShuffleManager.scala, line 602 in Utils.scala, etc. |
|
QA tests have finished for PR 2793 at commit
|
|
Test PASSed. |
|
meh - seems fine to me as a minor cleanup. Jenkins, test this please. If it passes we can merge it. |
|
Test build #23602 has started for PR 2793 at commit
|
|
Test build #23602 has finished for PR 2793 at commit
|
|
Test PASSed. |
|
@pwendell , can this be merged? |
|
Meh, I guess we might as well merge this if it still passes tests. Jenkins, retest this please. |
|
Jenkins, retest this please |
|
Test build #24344 has started for PR 2793 at commit
|
|
Test build #24344 has finished for PR 2793 at commit
|
|
Test PASSed. |
|
Alright, I've merged this into |
No description provided.