[SPARK-31175][SQL] Avoid creating reverse comparator for each compare in InterpretedOrdering#27938
Closed
Ngone51 wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-31175][SQL] Avoid creating reverse comparator for each compare in InterpretedOrdering#27938Ngone51 wants to merge 1 commit intoapache:masterfrom
Ngone51 wants to merge 1 commit intoapache:masterfrom
Conversation
|
Test build #119939 has finished for PR 27938 at commit
|
maropu
approved these changes
Mar 18, 2020
Member
Author
|
ping @cloud-fan @HyukjinKwon Please take a look, thanks! |
Contributor
|
thanks, merging to master! |
Member
Author
|
thanks all! |
Member
|
+1, late LGTM. |
sjincho
pushed a commit
to sjincho/spark
that referenced
this pull request
Apr 15, 2020
… in InterpretedOrdering ### What changes were proposed in this pull request? Prpend `-` to the compare result instead of creating a new reverse comparator for each compare when sorting in DESC order in InterpretedOrdering. ### Why are the changes needed? Currently, we'll create a new reverse comparator for each compare in InterpretedOrdering, which could generate lots of small and instant object and hurt JVM when there're plenty of data. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? Pass Jenkins. Closes apache#27938 from Ngone51/reverse_comparator. Authored-by: yi.wu <yi.wu@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Prpend
-to the compare result instead of creating a new reverse comparator for each compare when sorting in DESC order in InterpretedOrdering.Why are the changes needed?
Currently, we'll create a new reverse comparator for each compare in InterpretedOrdering, which could generate lots of small and instant object and hurt JVM when there're plenty of data.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass Jenkins.