[SPARK-30954][ML][R]Make file name the same as class name#27940
Closed
kevinyu98 wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-30954][ML][R]Make file name the same as class name#27940kevinyu98 wants to merge 1 commit intoapache:masterfrom
kevinyu98 wants to merge 1 commit intoapache:masterfrom
Conversation
Member
|
ok to test |
Member
|
cc @zhengruifeng and @srowen |
Member
|
Yep seems OK. CC @felixcheung just FHI |
dongjoon-hyun
approved these changes
Mar 17, 2020
|
Test build #119945 has finished for PR 27940 at commit
|
Contributor
|
retest this please |
|
Test build #119951 has finished for PR 27940 at commit
|
dongjoon-hyun
approved these changes
Mar 17, 2020
Member
There was a problem hiding this comment.
+1, LGTM. Merged to master/3.0.
Thank you, @kevinyu98 , @srowen , @huaxingao !
dongjoon-hyun
pushed a commit
that referenced
this pull request
Mar 17, 2020
This pr solved the same issue as [pr27919](#27919), but this one changes the file names based on comment from previous pr. ### What changes were proposed in this pull request? Make some of file names the same as class name in R package. ### Why are the changes needed? Make the file consistence ### Does this PR introduce any user-facing change? No ### How was this patch tested? run `./R/run-tests.sh` Closes #27940 from kevinyu98/spark-30954-r-v2. Authored-by: Qianyang Yu <qyu@us.ibm.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 6f0b0f1) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Member
|
Ok
|
Member
|
Thank you, @felixcheung ! |
sjincho
pushed a commit
to sjincho/spark
that referenced
this pull request
Apr 15, 2020
This pr solved the same issue as [pr27919](apache#27919), but this one changes the file names based on comment from previous pr. ### What changes were proposed in this pull request? Make some of file names the same as class name in R package. ### Why are the changes needed? Make the file consistence ### Does this PR introduce any user-facing change? No ### How was this patch tested? run `./R/run-tests.sh` Closes apache#27940 from kevinyu98/spark-30954-r-v2. Authored-by: Qianyang Yu <qyu@us.ibm.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr solved the same issue as pr27919, but this one changes the file names based on comment from previous pr.
What changes were proposed in this pull request?
Make some of file names the same as class name in R package.
Why are the changes needed?
Make the file consistence
Does this PR introduce any user-facing change?
No
How was this patch tested?
run
./R/run-tests.sh