[SPARK-30715][K8S][TESTS][FOLLOWUP] Update k8s client version in IT as well #27948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
|
Test build #119990 has finished for PR 27948 at commit
|
| protected var appLocator: String = _ | ||
|
|
||
| // Default memory limit is 1024M + 384M (minimum overhead constant) | ||
| private val baseMemory = s"${1024 + 384}Mi" |
Member
There was a problem hiding this comment.
Hi, @ScrapCodes . Do we need this change in this PR?
Member
Author
There was a problem hiding this comment.
Hi Dongjoon, Yes, it is part of updating the client version. Tests won't pass otherwise.
Member
Author
There was a problem hiding this comment.
To be precise, in 4.7.1 Quantity constructor tries to parse the amount into format and the amount. link
And in 4.6.4, It does not. link
More details here : fabric8io/kubernetes-client@c370d26
ScrapCodes
changed the title
dongjoon-hyun
changed the title
dongjoon-hyun
changed the title
dongjoon-hyun
approved these changes
Mar 22, 2020
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Merged to master.
Thank you, @ScrapCodes .
sjincho
pushed a commit
to sjincho/spark
that referenced
this pull request
Apr 15, 2020
…s well ### What changes were proposed in this pull request? This is a follow up for SPARK-30715 . Kubernetes client version in sync in integration-tests and kubernetes/core ### Why are the changes needed? More than once, the kubernetes client version has gone out of sync between integration tests and kubernetes/core. So brought them up in sync again and added a comment to save us from future need of this additional followup. ### Does this PR introduce any user-facing change? No ### How was this patch tested? Manually. Closes apache#27948 from ScrapCodes/follow-up-spark-30715. Authored-by: Prashant Sharma <prashsh1@in.ibm.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Member
|
Hi. |
dongjoon-hyun
pushed a commit
that referenced
this pull request
May 24, 2020
…s well ### What changes were proposed in this pull request? This is a follow up for SPARK-30715 . Kubernetes client version in sync in integration-tests and kubernetes/core ### Why are the changes needed? More than once, the kubernetes client version has gone out of sync between integration tests and kubernetes/core. So brought them up in sync again and added a comment to save us from future need of this additional followup. ### Does this PR introduce any user-facing change? No ### How was this patch tested? Manually. Closes #27948 from ScrapCodes/follow-up-spark-30715. Authored-by: Prashant Sharma <prashsh1@in.ibm.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 3799d2b) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow up for SPARK-30715 . Kubernetes client version in sync in integration-tests and kubernetes/core
Why are the changes needed?
More than once, the kubernetes client version has gone out of sync between integration tests and kubernetes/core. So brought them up in sync again and added a comment to save us from future need of this additional followup.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Manually.