[SPARK-31183][SQL][FOLLOWUP][3.0] Move rebase tests to AvroSuite and check the rebase flag out of function bodies#27977
Closed
MaxGekk wants to merge 2 commits intoapache:branch-3.0from
Closed
Conversation
…roSuite` and check the rebase flag out of function bodies"" This reverts commit f0bfdc5.
HyukjinKwon
approved these changes
Mar 22, 2020
Member
HyukjinKwon
left a comment
HyukjinKwon
left a comment
There was a problem hiding this comment.
LGTM if tests pass. Thanks @dongjoon-hyun and @MaxGekk
|
Test build #120151 has finished for PR 27977 at commit
|
cloud-fan
changed the title
AvroSuite and check the rebase flag out of function bodiesAvroSuite and check the rebase flag out of function bodies
Member
|
Merged to branch-3.0. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Mar 23, 2020
…d check the rebase flag out of function bodies ### What changes were proposed in this pull request? 1. The tests added by #27953 are moved from `AvroLogicalTypeSuite` to `AvroSuite`. 2. Checking of the `rebaseDateTime` flag is moved out from functions bodies. This is a backport of #27964 ### Why are the changes needed? 1. The tests are moved because they are not directly related to logical types. 2. Checking the flag out of functions bodies should improve performance. ### Does this PR introduce any user-facing change? No ### How was this patch tested? By running Avro tests via the command `build/sbt avro/test` Closes #27977 from MaxGekk/rebase-avro-datetime-followup-3.0. Authored-by: Maxim Gekk <max.gekk@gmail.com> Signed-off-by: HyukjinKwon <gurwls223@apache.org>
Member
|
Thank you, @MaxGekk and @HyukjinKwon ! |
Contributor
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
AvroLogicalTypeSuitetoAvroSuite.rebaseDateTimeflag is moved out from functions bodies.This is a backport of #27964
Why are the changes needed?
Does this PR introduce any user-facing change?
No
How was this patch tested?
By running Avro tests via the command
build/sbt avro/test