[SPARK-31253][SQL][FOLLOW-UP] simplify the code of calculating size metrics of AQE shuffle #28240
Closed
cloud-fan wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-31253][SQL][FOLLOW-UP] simplify the code of calculating size metrics of AQE shuffle #28240cloud-fan wants to merge 1 commit intoapache:masterfrom
cloud-fan wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
JkSelf
reviewed
Apr 17, 2020
| val partitionDataSizeMetrics = metrics("partitionDataSize") | ||
| driverAccumUpdates ++= dataSizes.map(partitionDataSizeMetrics.id -> _) | ||
| // Set sum value to "partitionDataSize" metric. | ||
| partitionDataSizeMetrics.set(dataSizes.sum) |
There was a problem hiding this comment.
why use the dataSizes's sum not partitionDataSizes's sum ?
Contributor
Author
There was a problem hiding this comment.
partitionDataSizes.foreach { dataSizes => so dateSizes = partitionDataSizes.get
|
Test build #121405 has finished for PR 28240 at commit
|
Member
|
Thanks! Merged to master/3.0 |
Contributor
|
Merged to master only, please manually backport this to 3.0. Thanks! |
Contributor
Author
|
We haven't decided to backport the AQE SQL metrics yet, so this PR can't be backported for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
A followup of #28175:
Why are the changes needed?
code simplification
Does this PR introduce any user-facing change?
no
How was this patch tested?
existing tests