[SPARK-31344][CORE][3.0] Polish implementation of barrier() and allGather()#28283
Closed
Ngone51 wants to merge 1 commit intoapache:branch-3.0from
Closed
[SPARK-31344][CORE][3.0] Polish implementation of barrier() and allGather()#28283Ngone51 wants to merge 1 commit intoapache:branch-3.0from
Ngone51 wants to merge 1 commit intoapache:branch-3.0from
Conversation
### What changes were proposed in this pull request? 1. Combine `BarrierRequestToSync` and `AllGatherRequestToSync` into `RequestToSync`, which is distinguished by `RequestMethod` type. 2. Remove unnecessary Json serialization/deserialization 3. Clean up some codes to make runBarrier() and `BarrierCoordinator` more general 4. Remove unused imports. ### Why are the changes needed? To make codes simpler for better maintain in the future. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? This is pure code refactor, so should be covered by existed tests. Closes apache#28117 from Ngone51/refactor_barrier. Authored-by: yi.wu <yi.wu@databricks.com> Signed-off-by: Xingbo Jiang <xingbo.jiang@databricks.com>
Member
Author
|
cc @jiangxb1987 |
|
Test build #121579 has finished for PR 28283 at commit
|
Member
|
Hi, @Ngone51 . Shall we use |
Member
Author
|
Sure, I'll follow it. |
Ngone51
changed the title
Member
|
cc @cloud-fan |
Contributor
|
thanks, merging to 3.0! |
cloud-fan
pushed a commit
that referenced
this pull request
Apr 23, 2020
…ther() ### What changes were proposed in this pull request? Backport this in order to backport #28245 more smoothly later. 1. Combine `BarrierRequestToSync` and `AllGatherRequestToSync` into `RequestToSync`, which is distinguished by `RequestMethod` type. 2. Remove unnecessary Json serialization/deserialization 3. Clean up some codes to make runBarrier() and `BarrierCoordinator` more general 4. Remove unused imports. ### Why are the changes needed? To make codes simpler for better maintain in the future. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? This is pure code refactor, so should be covered by existed tests. Closes #28283 from Ngone51/backport-3.0. Authored-by: yi.wu <yi.wu@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Member
Author
|
thanks all! |
Member
|
Thank you all! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Backport this in order to backport #28245 more smoothly later.
Combine
BarrierRequestToSyncandAllGatherRequestToSyncintoRequestToSync, which is distinguished byRequestMethodtype.Remove unnecessary Json serialization/deserialization
Clean up some codes to make runBarrier() and
BarrierCoordinatormore generalRemove unused imports.
Why are the changes needed?
To make codes simpler for better maintain in the future.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
This is pure code refactor, so should be covered by existed tests.