[SPARK-31557][SQL][TESTS][FOLLOWUP] Check rebasing in all legacy formatters#28398
Closed
MaxGekk wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-31557][SQL][TESTS][FOLLOWUP] Check rebasing in all legacy formatters#28398MaxGekk wants to merge 2 commits intoapache:masterfrom
MaxGekk wants to merge 2 commits intoapache:masterfrom
Conversation
Member
Author
|
@bersprockets @cloud-fan While working on the fix for legacy timestamp formatters, I have found that the round trip tests for dates are not enough. Need to test in each direction separately. Also existing tests don't cover all legacy parsers. |
|
Test build #122010 has finished for PR 28398 at commit
|
Contributor
|
thanks, merging to master/3.0! |
cloud-fan
pushed a commit
that referenced
this pull request
Apr 29, 2020
…atters ### What changes were proposed in this pull request? - Check all available legacy formats in the tests added by #28345 - Check dates rebasing in legacy parsers for only one direction either days -> string or string -> days. ### Why are the changes needed? Round trip tests can hide issues in dates rebasing. For example, if we remove rebasing from legacy parsers (from `parse()` and `format()`) the tests will pass. ### Does this PR introduce any user-facing change? No ### How was this patch tested? By running `DateFormatterSuite`. Closes #28398 from MaxGekk/test-rebasing-in-legacy-date-formatter. Authored-by: Max Gekk <max.gekk@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit 73eac75) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Round trip tests can hide issues in dates rebasing. For example, if we remove rebasing from legacy parsers (from
parse()andformat()) the tests will pass.Does this PR introduce any user-facing change?
No
How was this patch tested?
By running
DateFormatterSuite.