[SPARK-31557][SQL] Fix timestamps rebasing in legacy parsers#28408
Closed
MaxGekk wants to merge 3 commits intoapache:masterfrom
Closed
[SPARK-31557][SQL] Fix timestamps rebasing in legacy parsers#28408MaxGekk wants to merge 3 commits intoapache:masterfrom
MaxGekk wants to merge 3 commits intoapache:masterfrom
Conversation
Member
Author
|
@cloud-fan @bersprockets @HyukjinKwon Please, review this PR. |
|
Test build #122080 has finished for PR 28408 at commit
|
Member
Author
|
jenkins, retest this, please |
cloud-fan
approved these changes
Apr 30, 2020
|
Test build #122108 has finished for PR 28408 at commit
|
Contributor
|
retest this please |
|
Test build #122117 has finished for PR 28408 at commit
|
Contributor
|
thanks, merging to master/3.0! |
cloud-fan
pushed a commit
that referenced
this pull request
Apr 30, 2020
In the PR, I propose to fix two legacy timestamp formatter `LegacySimpleTimestampFormatter` and `LegacyFastTimestampFormatter` to perform micros rebasing in parsing/formatting from/to strings. Legacy timestamps formatters operate on the hybrid calendar (Julian + Gregorian), so, the input micros should be rebased to have the same date-time fields as in Proleptic Gregorian calendar used by Spark SQL, see SPARK-26651. Yes Added tests to `TimestampFormatterSuite` Closes #28408 from MaxGekk/fix-rebasing-in-legacy-timestamp-formatter. Authored-by: Max Gekk <max.gekk@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit c09cfb9) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to fix two legacy timestamp formatter
LegacySimpleTimestampFormatterandLegacyFastTimestampFormatterto perform micros rebasing in parsing/formatting from/to strings.Why are the changes needed?
Legacy timestamps formatters operate on the hybrid calendar (Julian + Gregorian), so, the input micros should be rebased to have the same date-time fields as in Proleptic Gregorian calendar used by Spark SQL, see SPARK-26651.
Does this PR introduce any user-facing change?
Yes
How was this patch tested?
Added tests to
TimestampFormatterSuite