Update ChiSqSelectorExample to show import#28533
Closed
gfosco wants to merge 1 commit intoapache:masterfrom
Closed
Update ChiSqSelectorExample to show import#28533gfosco wants to merge 1 commit intoapache:masterfrom
gfosco wants to merge 1 commit intoapache:masterfrom
Conversation
I found this via the mailing list, a user had submitted this change to the spark-website repo and was told to submit it here. Six times that happened. So here is the change, just moving the import into the example block. ref: http://apache-spark-developers-list.1001551.n3.nabble.com/Block-a-user-from-spark-website-who-repeatedly-open-the-invalid-same-PR-td28759.html
|
Can one of the admins verify this patch? |
HyukjinKwon
reviewed
May 15, 2020
| import spark.implicits._ | ||
|
|
||
| // $example on$ | ||
| import spark.implicits._ |
Member
There was a problem hiding this comment.
I think this isn't required when you run a Spark shell. Looks intentionally excluded given that val spark initialization isn't involved already.
Author
There was a problem hiding this comment.
Ok, I'll go ahead and close the PR. Thanks for the review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found this via the mailing list, a user had submitted this change to the spark-website repo and was told to submit it here. Six times that happened. So here is the change, just moving the import into the example block.
ref: http://apache-spark-developers-list.1001551.n3.nabble.com/Block-a-user-from-spark-website-who-repeatedly-open-the-invalid-same-PR-td28759.html
What changes were proposed in this pull request?
Moving 1 line into an example block.
Why are the changes needed?
To make a website example clearer.
Does this PR introduce any user-facing change?
No