Skip to content

[SPARK-25351][PYTHON][TEST][FOLLOWUP] Fix test assertions to be consistent#28659

Closed
BryanCutler wants to merge 1 commit into
apache:masterfrom
BryanCutler:arrow-category-test-fix-SPARK-25351
Closed

[SPARK-25351][PYTHON][TEST][FOLLOWUP] Fix test assertions to be consistent#28659
BryanCutler wants to merge 1 commit into
apache:masterfrom
BryanCutler:arrow-category-test-fix-SPARK-25351

Conversation

@BryanCutler
Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

Followup to make assertions from recent test consistent with the rest of the module

Why are the changes needed?

Better to use assertions from unittest and be consistent

Does this PR introduce any user-facing change?

No

How was this patch tested?

Existing tests

Copy link
Copy Markdown
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests pass

@SparkQA
Copy link
Copy Markdown

SparkQA commented May 28, 2020

Test build #123204 has finished for PR 28659 at commit 03fe85c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Copy Markdown
Member

Merged to master

@BryanCutler
Copy link
Copy Markdown
Member Author

Thanks @HyukjinKwon !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants