Skip to content

Update RoaringBitmap to 0.4.3#2938

Closed
lemire wants to merge 1 commit intoapache:masterfrom
lemire:master
Closed

Update RoaringBitmap to 0.4.3#2938
lemire wants to merge 1 commit intoapache:masterfrom
lemire:master

Conversation

@lemire
Copy link
Copy Markdown
Contributor

@lemire lemire commented Oct 25, 2014

Roaring has been updated to version 0.4.3. We fixed a rarely occurring bug with serialization. No API or format changes were made.

@AmplabJenkins
Copy link
Copy Markdown

Can one of the admins verify this patch?

@JoshRosen
Copy link
Copy Markdown
Contributor

Thanks for the pointer! I'm going to let Jenkins test this and then I'll merge it in.

Jenkins, this is ok to test.

@JoshRosen
Copy link
Copy Markdown
Contributor

Oh, one minor comment: do you mind editing the title of this PR to be a little more descriptive, e.g. "Update RoaringBitmap to 0.4.3?" The title/description will become the commit message when I merge this and I can't edit your PR description or title due to the way that the ASF grants us GitHub permissions.

@lemire lemire changed the title Recommended bug fix release Update RoaringBitmap to 0.4.3 Oct 25, 2014
@lemire
Copy link
Copy Markdown
Contributor Author

lemire commented Oct 25, 2014

@JoshRosen Renaming done. ;-)

@JoshRosen
Copy link
Copy Markdown
Contributor

Jenkins, retest this please.

@SparkQA
Copy link
Copy Markdown

SparkQA commented Oct 25, 2014

Test build #22186 has started for PR 2938 at commit 431f3a0.

  • This patch merges cleanly.

@SparkQA
Copy link
Copy Markdown

SparkQA commented Oct 25, 2014

Test build #22186 has finished for PR 2938 at commit 431f3a0.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22186/
Test FAILed.

@JoshRosen
Copy link
Copy Markdown
Contributor

Jenkins, retest this please.

@SparkQA
Copy link
Copy Markdown

SparkQA commented Oct 25, 2014

Test build #22219 has started for PR 2938 at commit 431f3a0.

  • This patch merges cleanly.

@SparkQA
Copy link
Copy Markdown

SparkQA commented Oct 25, 2014

Test build #22219 timed out for PR 2938 at commit 431f3a0 after a configured wait of 120m.

@AmplabJenkins
Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22219/
Test FAILed.

@JoshRosen
Copy link
Copy Markdown
Contributor

I think I've identified the cause of the test flakiness, so I've reverted the Snappy upgrade patch.

Jenkins, retest this please.

@JoshRosen
Copy link
Copy Markdown
Contributor

Jenkins, retest this please.

@SparkQA
Copy link
Copy Markdown

SparkQA commented Oct 26, 2014

Test build #22237 has started for PR 2938 at commit 431f3a0.

  • This patch merges cleanly.

@SparkQA
Copy link
Copy Markdown

SparkQA commented Oct 26, 2014

Test build #22237 has finished for PR 2938 at commit 431f3a0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22237/
Test PASSed.

@JoshRosen
Copy link
Copy Markdown
Contributor

Now that our build / tests have stabilized, I'm going to merge this. Thanks!

@asfgit asfgit closed this in b759540 Oct 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants