[SPARK-32652][SQL] ObjectSerializerPruning fails for RowEncoder#29467
Closed
cloud-fan wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-32652][SQL] ObjectSerializerPruning fails for RowEncoder#29467cloud-fan wants to merge 1 commit intoapache:masterfrom
cloud-fan wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
Member
|
Thank you for pinging me, @cloud-fan . |
viirya
reviewed
Aug 18, 2020
Comment on lines
+132
to
+133
| // `name` in `GetStructField` affects `comparePlans`. Maybe we can ignore | ||
| // `name` in `GetStructField.equals`? |
Member
There was a problem hiding this comment.
Sounds good. When we compare GetStructField semantically, name is actually ignored.
Member
There was a problem hiding this comment.
+1. Could we remove this comment and file jira for this issue before merging?
Member
There was a problem hiding this comment.
Let me just merge this. In the PR that actually ignores the equality, we can remove this comment and also the codes clearing the name below.
Contributor
Author
There was a problem hiding this comment.
Note: I just copied this comment from the existing test case above. If we can fix it, we should remove comments from both test cases.
|
Test build #127589 has finished for PR 29467 at commit
|
maropu
approved these changes
Aug 19, 2020
HyukjinKwon
approved these changes
Aug 19, 2020
Member
|
Merged to master and branch-3.0. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Aug 19, 2020
### What changes were proposed in this pull request? Update `ObjectSerializerPruning.alignNullTypeInIf`, to consider the isNull check generated in `RowEncoder`, which is `Invoke(inputObject, "isNullAt", BooleanType, Literal(index) :: Nil)`. ### Why are the changes needed? Query fails if we don't fix this bug, due to type mismatch in `If`. ### Does this PR introduce _any_ user-facing change? Yes, the failed query can run after this fix. ### How was this patch tested? new tests Closes #29467 from cloud-fan/bug. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: HyukjinKwon <gurwls223@apache.org> (cherry picked from commit f33b64a) Signed-off-by: HyukjinKwon <gurwls223@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Update
ObjectSerializerPruning.alignNullTypeInIf, to consider the isNull check generated inRowEncoder, which isInvoke(inputObject, "isNullAt", BooleanType, Literal(index) :: Nil).Why are the changes needed?
Query fails if we don't fix this bug, due to type mismatch in
If.Does this PR introduce any user-facing change?
Yes, the failed query can run after this fix.
How was this patch tested?
new tests