[MINOR][DOCS] Add KMeansSummary and InheritableThread to documentation#29470
Closed
srowen wants to merge 2 commits intoapache:masterfrom
Closed
[MINOR][DOCS] Add KMeansSummary and InheritableThread to documentation#29470srowen wants to merge 2 commits intoapache:masterfrom
srowen wants to merge 2 commits intoapache:masterfrom
Conversation
Member
Author
|
CC @huaxingao right? |
huaxingao
approved these changes
Aug 18, 2020
|
Test build #127600 has finished for PR 29470 at commit
|
Member
|
Oh actually we should add it into |
HyukjinKwon
approved these changes
Aug 19, 2020
HyukjinKwon
changed the title
Member
|
Merged to master. |
Member
|
BTW your new profile pic looks nice @srowen! |
|
Test build #127621 has finished for PR 29470 at commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The class
KMeansSummaryin pyspark is not included inclustering.py's__all__declaration. It isn't included in the docs as a result.InheritableThreadandKMeansSummaryshould be into corresponding RST files for documentation.Why are the changes needed?
It seems like an oversight to not include this as all similar "summary" classes are.
InheritableThreadshould also be documented.Does this PR introduce any user-facing change?
I don't believe there are functional changes. It should make this public class appear in docs.
How was this patch tested?
Existing tests / N/A.