[MINOR]Fix Long Type mismatch#29483
Closed
kelvin-qin wants to merge 1 commit intoapache:masterfrom
kelvin-qin:patch-1
Closed
[MINOR]Fix Long Type mismatch#29483kelvin-qin wants to merge 1 commit intoapache:masterfrom kelvin-qin:patch-1
kelvin-qin wants to merge 1 commit intoapache:masterfrom
kelvin-qin:patch-1
Conversation
The maximumSize(long size) need long Type params ,but conf.get(config.STORAGE_LOCAL_DISK_BY_EXECUTORS_CACHE_SIZE) return Int Type,So Type mismatch,just fix it.
|
Can one of the admins verify this patch? |
Member
|
I don't think it's worth fixing it. isn't it a legitimate upcasting? |
Member
|
This doesn't do anything. It's an int conf. Obviously, it works to pass it as a long param. |
Author
|
fine,thank you for closing it . |
Author
|
Actually,the conf.get return ConfigEntry[Int] type,This will cause a warning or error message in IDE.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The maximumSize(long size) need long Type param ,but conf.get(config.STORAGE_LOCAL_DISK_BY_EXECUTORS_CACHE_SIZE) return Int Type,So Type mismatch,just fix it.
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?