[MINOR][SQL] Add missing documentation for LongType mapping#29534
Closed
yeshengm wants to merge 1 commit intoapache:masterfrom
Closed
[MINOR][SQL] Add missing documentation for LongType mapping#29534yeshengm wants to merge 1 commit intoapache:masterfrom
yeshengm wants to merge 1 commit intoapache:masterfrom
Conversation
HyukjinKwon
changed the title
HyukjinKwon
changed the title
|
Test build #127856 has finished for PR 29534 at commit
|
HyukjinKwon
approved these changes
Aug 25, 2020
HyukjinKwon
pushed a commit
that referenced
this pull request
Aug 25, 2020
### What changes were proposed in this pull request? Added Java docs for Long data types in the Row class. ### Why are the changes needed? The Long datatype is somehow missing in Row.scala's `apply` and `get` methods. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing UTs. Closes #29534 from yeshengm/docs-fix. Authored-by: Yesheng Ma <kimi.ysma@gmail.com> Signed-off-by: HyukjinKwon <gurwls223@apache.org> (cherry picked from commit 3eee915) Signed-off-by: HyukjinKwon <gurwls223@apache.org>
HyukjinKwon
pushed a commit
that referenced
this pull request
Aug 25, 2020
### What changes were proposed in this pull request? Added Java docs for Long data types in the Row class. ### Why are the changes needed? The Long datatype is somehow missing in Row.scala's `apply` and `get` methods. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing UTs. Closes #29534 from yeshengm/docs-fix. Authored-by: Yesheng Ma <kimi.ysma@gmail.com> Signed-off-by: HyukjinKwon <gurwls223@apache.org> (cherry picked from commit 3eee915) Signed-off-by: HyukjinKwon <gurwls223@apache.org>
Member
|
Merged to master, branch-3.0 and branch-2.4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added Java docs for Long data types in the Row class.
Why are the changes needed?
The Long datatype is somehow missing in Row.scala's
applyandgetmethods.Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing UTs.