Skip to content

[SPARK-28612][SQL][FOLLOWUP] Correct method doc of DataFrameWriterV2.replace()#29568

Closed
HeartSaVioR wants to merge 1 commit intoapache:masterfrom
HeartSaVioR:SPARK-28612-FOLLOWUP-fix-doc-nit
Closed

[SPARK-28612][SQL][FOLLOWUP] Correct method doc of DataFrameWriterV2.replace()#29568
HeartSaVioR wants to merge 1 commit intoapache:masterfrom
HeartSaVioR:SPARK-28612-FOLLOWUP-fix-doc-nit

Conversation

@HeartSaVioR
Copy link
Contributor

What changes were proposed in this pull request?

This patch corrects the method doc of DataFrameWriterV2.replace() which explanation of exception is described oppositely.

Why are the changes needed?

The method doc is incorrect.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Only doc change.

@HeartSaVioR
Copy link
Contributor Author

HeartSaVioR commented Aug 28, 2020

cc. @rdblue @brkyvz as author & merger of the commit

This needs to be in both master and branch-3.0.

@HyukjinKwon
Copy link
Member

Merged to master and branch-3.0.

HyukjinKwon pushed a commit that referenced this pull request Aug 28, 2020
…replace()

### What changes were proposed in this pull request?

This patch corrects the method doc of DataFrameWriterV2.replace() which explanation of exception is described oppositely.

### Why are the changes needed?

The method doc is incorrect.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Only doc change.

Closes #29568 from HeartSaVioR/SPARK-28612-FOLLOWUP-fix-doc-nit.

Authored-by: Jungtaek Lim (HeartSaVioR) <kabhwan.opensource@gmail.com>
Signed-off-by: HyukjinKwon <gurwls223@apache.org>
(cherry picked from commit 73bfed3)
Signed-off-by: HyukjinKwon <gurwls223@apache.org>
@SparkQA
Copy link

SparkQA commented Aug 28, 2020

Test build #127977 has finished for PR 29568 at commit dd87489.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HeartSaVioR
Copy link
Contributor Author

Thanks for the quick reviewing and merging!

@HeartSaVioR HeartSaVioR deleted the SPARK-28612-FOLLOWUP-fix-doc-nit branch August 28, 2020 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants