Skip to content

[MINOR][DOCS] Fix the Binder link to point the quickstart notebook correctly#29597

Closed
HyukjinKwon wants to merge 1 commit intoapache:masterfrom
HyukjinKwon:minor-link-quickstart
Closed

[MINOR][DOCS] Fix the Binder link to point the quickstart notebook correctly#29597
HyukjinKwon wants to merge 1 commit intoapache:masterfrom
HyukjinKwon:minor-link-quickstart

Conversation

@HyukjinKwon
Copy link
Member

What changes were proposed in this pull request?

This PR fixes the link of Binder in Quickstart notebook and documentation.

From:

https://mybinder.org/v2/gh/databricks/apache/master?filepath=python%2Fdocs%2Fsource%2Fgetting_started%2Fquickstart.ipynb

To:

https://mybinder.org/v2/gh/apache/spark/master?filepath=python%2Fdocs%2Fsource%2Fgetting_started%2Fquickstart.ipynb

This link is the same as the one in RST files:

.. _binder: https://mybinder.org/v2/gh/apache/spark/{0}?filepath=python%2Fdocs%2Fsource%2Fgetting_started%2Fquickstart.ipynb

Why are the changes needed?

The link was wrong, and points out non-existent file and repo.

Does this PR introduce any user-facing change?

Yes, it will fixes the link so users can correctly try Binder.

How was this patch tested?

Manually tested by building the documentation.

@HyukjinKwon
Copy link
Member Author

Let me just merge this. I am 100% sure this is correct fix, and this is doc-only.

@SparkQA
Copy link

SparkQA commented Aug 31, 2020

Test build #128096 has finished for PR 29597 at commit 3f2ce89.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon HyukjinKwon deleted the minor-link-quickstart branch December 7, 2020 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants