[SPARK-32826][SQL] Set the right column size for the null type in SparkGetColumnsOperation #29687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @cloud-fan @maropu @dongjoon-hyun, and thanks very much~ |
yaooqinn
changed the title
|
Test build #128433 has finished for PR 29687 at commit
|
maropu
approved these changes
Sep 9, 2020
maropu
changed the title
cloud-fan
reviewed
Sep 10, 2020
| private def getColumnSize(typ: DataType): Option[Int] = typ match { | ||
| case dt @ (BooleanType | _: NumericType | DateType | TimestampType | CalendarIntervalType) => | ||
| case dt @ (BooleanType | _: NumericType | DateType | TimestampType | | ||
| CalendarIntervalType | NullType) => |
Contributor
There was a problem hiding this comment.
so it's not a test only PR. Can we remove [TEST] from PR title?
cloud-fan
approved these changes
Sep 10, 2020
yaooqinn
changed the title
Contributor
|
please also update the PR description to mention the non-test change. |
yaooqinn
changed the title
Member
Author
|
updated, thanks for suggestions |
Contributor
|
thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In Spark 3.0.0, the SparkGetColumnsOperation can not recognize NULL columns but now we can because the side effect of https://issues.apache.org/jira/browse/SPARK-32696 / f14f374, but the test coverage for this change was not added.
In Spark, the column size for null fields should be 1, in this PR, we set the right column size for the null type.
Why are the changes needed?
test coverage and fix the client-side information about the null type through jdbc
Does this PR introduce any user-facing change?
NO
How was this patch tested?
added ut both for this pr and SPARK-32696