[SPARK-32306][SQL][DOCS][2.4] Clarify the result of percentile_approx()#29847
Closed
MaxGekk wants to merge 1 commit intoapache:branch-2.4from
Closed
[SPARK-32306][SQL][DOCS][2.4] Clarify the result of percentile_approx()#29847MaxGekk wants to merge 1 commit intoapache:branch-2.4from
percentile_approx()#29847MaxGekk wants to merge 1 commit intoapache:branch-2.4from
Conversation
More precise description of the result of the `percentile_approx()` function and its synonym `approx_percentile()`. The proposed sentence clarifies that the function returns **one of elements** (or array of elements) from the input column. To improve Spark docs and avoid misunderstanding of the function behavior. No `./dev/scalastyle` Closes apache#29835 from MaxGekk/doc-percentile_approx. Authored-by: Max Gekk <max.gekk@gmail.com> Signed-off-by: Liang-Chi Hsieh <viirya@gmail.com> (cherry picked from commit 7c14f17) Signed-off-by: Max Gekk <max.gekk@gmail.com>
|
Test build #129012 has finished for PR 29847 at commit
|
HyukjinKwon
approved these changes
Sep 23, 2020
Member
|
Merged to branch-2.4 |
HyukjinKwon
pushed a commit
that referenced
this pull request
Sep 23, 2020
…x()` ### What changes were proposed in this pull request? More precise description of the result of the `percentile_approx()` function and its synonym `approx_percentile()`. The proposed sentence clarifies that the function returns **one of elements** (or array of elements) from the input column. ### Why are the changes needed? To improve Spark docs and avoid misunderstanding of the function behavior. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? `./dev/scalastyle` Authored-by: Max Gekk <max.gekkgmail.com> Signed-off-by: Liang-Chi Hsieh <viiryagmail.com> (cherry picked from commit 7c14f17) Signed-off-by: Max Gekk <max.gekkgmail.com> Closes #29847 from MaxGekk/doc-percentile_approx-2.4. Authored-by: Max Gekk <max.gekk@gmail.com> Signed-off-by: HyukjinKwon <gurwls223@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
More precise description of the result of the
percentile_approx()function and its synonymapprox_percentile(). The proposed sentence clarifies that the function returns one of elements (or array of elements) from the input column.Why are the changes needed?
To improve Spark docs and avoid misunderstanding of the function behavior.
Does this PR introduce any user-facing change?
No
How was this patch tested?
./dev/scalastyleAuthored-by: Max Gekk max.gekk@gmail.com
Signed-off-by: Liang-Chi Hsieh viirya@gmail.com
(cherry picked from commit 7c14f17)
Signed-off-by: Max Gekk max.gekk@gmail.com