-
Notifications
You must be signed in to change notification settings - Fork 29.1k
[SPARK-33086][PYTHON] Add static annotations for pyspark.resource #29969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@zero323, let's file a separate JIRA instead of making followups at SPARK-32714 since that ticket basically targets to port as is. It's easier to revert, edit the fixed version, etc. when there's a separate JIRA so it's usually more preferred to create a separate JIRA when possible (at least in this project as far as I can tell). |
Sure thing. Please give me a second. |
HyukjinKwon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Yeah, this is fine too. LGTM |
|
Test build #129517 has finished for PR 29969 at commit
|
|
Test build #129518 has finished for PR 29969 at commit
|
|
Sorry, @HyukjinKwon one more minor style change. |
|
Kubernetes integration test starting |
|
Test build #129519 has finished for PR 29969 at commit
|
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
|
Kubernetes integration test status success |
|
Merged to master. |
What changes were proposed in this pull request?
This PR replaces dynamically generated annotations for following modules:
pyspark.resource.informationpyspark.resource.profilepyspark.resource.requestsWhy are the changes needed?
These modules where not manually annotated in
pyspark-stubs, but are part of the public API and we should provide more precise annotations.Does this PR introduce any user-facing change?
No.
How was this patch tested?
MyPy tests: