Skip to content

Conversation

@zero323
Copy link
Member

@zero323 zero323 commented Oct 10, 2020

What changes were proposed in this pull request?

Remove unused typing.Optional import from pyspark.resource.profile stub.

Why are the changes needed?

Since SPARK-32319 we don't allow unused imports. However, this one slipped both local and CI tests for some reason.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Existing tests and mypy check.

@SparkQA
Copy link

SparkQA commented Oct 10, 2020

Test build #129629 has finished for PR 30002 at commit cea28c7.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Oct 10, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34233/

@SparkQA
Copy link

SparkQA commented Oct 10, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34233/

@zero323
Copy link
Member Author

zero323 commented Oct 10, 2020

cc @HyukjinKwon (sorry, I should've seen that).

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's okay since the PR is already open but let's avoid fixing only a couple of in a separate PR in general. They don't affect the main codes and can be fixed together when you touch these codes later.

@HyukjinKwon
Copy link
Member

Merged to master.

zhengruifeng pushed a commit to zhengruifeng/spark that referenced this pull request Oct 12, 2020
…esource.profile stub

### What changes were proposed in this pull request?

Remove unused `typing.Optional` import from `pyspark.resource.profile` stub.

### Why are the changes needed?

Since SPARK-32319 we don't allow unused imports.  However, this one slipped both local and CI tests for some reason.

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

Existing tests and mypy check.

Closes apache#30002 from zero323/SPARK-33086-FOLLOWUP.

Authored-by: zero323 <mszymkiewicz@gmail.com>
Signed-off-by: HyukjinKwon <gurwls223@apache.org>
@zero323
Copy link
Member Author

zero323 commented Oct 12, 2020

It's okay since the PR is already open but let's avoid fixing only a couple of in a separate PR in general. They don't affect the main codes and can be fixed together when you touch these codes later.

Noted. I couldn't identify why it didn't trigger error in CI and thought it is better to fix it now, before it starts failing build at some point in the future.

Thanks.

@zero323 zero323 deleted the SPARK-33086-FOLLOWUP branch October 12, 2020 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants