Skip to content

Conversation

@ScrapCodes
Copy link
Member

What changes were proposed in this pull request?

test-only - > testOnly in docs across the project.

Why are the changes needed?

Since the sbt version is updated, the older way or running i.e. test-only is no longer valid.

Does this PR introduce any user-facing change?

docs update.

How was this patch tested?

Manually.

…ld/sbt references to test-only with testOnly.
@HyukjinKwon
Copy link
Member

As a reminder, we'll have to update https://spark.apache.org/developer-tools.html too.

@ScrapCodes
Copy link
Member Author

ScrapCodes commented Oct 13, 2020

As a reminder, we'll have to update https://spark.apache.org/developer-tools.html too.

@HyukjinKwon I did a quick pass. this doc looks good. Are you referring to something specific.

@HyukjinKwon
Copy link
Member

HyukjinKwon commented Oct 13, 2020

I just meant this one occurrence of test-only :-)

Screen Shot 2020-10-13 at 9 29 51 PM

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-33129][BUILD][DOCS] Follow up to SPARK-21708, updating the build/sbt references to test-only with testOnly. [SPARK-33129][BUILD][DOCS] Updating the build/sbt references to test-only with testOnly for SBT 1.3.x Oct 13, 2020
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you, @ScrapCodes and @HyukjinKwon .
Ya. Website update is needed too in spark-website repo.
Merged to master.

srowen pushed a commit to apache/spark-website that referenced this pull request Oct 15, 2020
See also apache/spark#30028. After SBT was upgraded to 1.3, `test-only` should be `testOnly`.

Author: HyukjinKwon <gurwls223@apache.org>

Closes #295 from HyukjinKwon/test-only-sbt-upgrade.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants